Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gray out labels when disabled #648

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Gray out labels when disabled #648

merged 2 commits into from
Apr 10, 2018

Conversation

bevacqua
Copy link
Contributor

@bevacqua bevacqua commented Apr 10, 2018 •
edited
Loading

This PR mostly grays out labels when components are disabled, so that it's a bit more obvious that they're disabled.

File Picker Before/After

screen shot 2018-04-10 at 12 52 10

screen shot 2018-04-10 at 12 52 04

Select Before/After

screen shot 2018-04-10 at 12 53 08

screen shot 2018-04-10 at 12 53 12

Checkbox Before/After

screen shot 2018-04-10 at 12 53 58

screen shot 2018-04-10 at 12 53 48

Radio Before/After

screen shot 2018-04-10 at 12 54 38

screen shot 2018-04-10 at 12 54 33

Switch Before/After

screen shot 2018-04-10 at 12 56 02

screen shot 2018-04-10 at 12 56 08

Textarea Before/After

screen shot 2018-04-10 at 13 02 23

screen shot 2018-04-10 at 13 02 18

Password Before/After (all text fields change the same way)

screen shot 2018-04-10 at 13 04 50

screen shot 2018-04-10 at 13 04 44

@bevacqua bevacqua requested review from snide and cchaos April 10, 2018 16:05
snide
snide approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. Only problem is it isn't accessible from a color contrast standpoint. It's debatable whether that's needed for disabled items. We certainly fudge the rules in other places. I think we're OK.

https://ux.stackexchange.com/questions/80881/do-disabled-buttons-still-need-to-be-contrast-compliant-for-accessibility

@bevacqua bevacqua merged commit bce21cf into elastic:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@cchaos cchaos Awaiting requested review from cchaos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bevacqua @snide